• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mozilla-services / cliquet / 2726
100%
master: %

Build:
Build:
LAST BUILD BRANCH: 186-215-add-sqlachemy-pooling
DEFAULT BRANCH: master
Ran 18 Nov 2015 12:06PM UTC
Jobs 6
Files 79
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2726

push

travis-ci

leplatrem
Load plugins after setting up authn/authz

While developing kinto-attachment, we realized that if plugins were included
before setting-up authn/authz, their views could not be protected by permissions.

For example, when a plugin defines a plugin like this in a view:

```python

    upload = Service(name="upload",
                     path="/upload",
                     description="",
                     factory=RouteFactory)
    @upload.get(permission="upload")
    def upload_get(request):
        return {"ok": True}

```

The factory is taken into account, but the authorization policy was never
called!

With this change, the plugins are included after ``cliquet.initialization.setup_authentication()``. Thus after ``config.include("pyramid_multiauth")`` thus after setting
up the authorization policy from setting ``multiauth.authorization_policy``.

The side-effet of this is that plugins cannot set default settings regarding auth.
It was the case of *cliquet-fxa* which defines an implicit setting ``multiauth.policy.fxa.use`` that allowed to just to specify ``fxa`` in the ``multiauth.policies`` setting.

The setting ``multiauth.policy.fxa.use`` must now be defined explicitly.

3 of 3 new or added lines in 1 file covered. (100.0%)

8059 of 8087 relevant lines covered (99.65%)

2.99 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2726.1 (TOX_ENV=py27) 18 Nov 2015 12:07PM UTC 0
99.63
Travis Job 2726.1
2 2726.2 (TOX_ENV=py34) 18 Nov 2015 12:08PM UTC 0
99.63
Travis Job 2726.2
3 2726.3 (TOX_ENV=pypy) 18 Nov 2015 12:14PM UTC 0
99.65
Travis Job 2726.3
4 2726.4 (TOX_ENV=py27-raw) 18 Nov 2015 12:06PM UTC 0
Travis Job 2726.4
5 2726.5 (TOX_ENV=flake8) 18 Nov 2015 12:06PM UTC 0
Travis Job 2726.5
6 2726.6 (TOX_ENV=docs) 18 Nov 2015 12:08PM UTC 0
Travis Job 2726.6
Source Files on build 2726
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2726
  • 4dc068b0 on github
  • Next Build on order-include-plugins (#2727)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc