igniterealtime / Smack / #2492

39%

master: 40%

push

github-actions

Bookmark parsing should not require non-empty nick

XEP-0048 defines an optional nickname for a bookmarked conference room, using an element named 'nick'.

Some clients have been observed to include an empty 'nick' element (instead of no such element) when a nickname is not stored as part of the bookmark.

Smack should not fail to parse these elements. Without the change in this commit, it fails with the following exception:

```
org.jxmpp.stringprep.XmppStringprepException: Argument can't be the empty string
    at org.jxmpp.stringprep.XmppStringPrepUtil.throwIfEmptyString(XmppStringPrepUtil.java:131)
    at org.jxmpp.stringprep.XmppStringPrepUtil.resourceprep(XmppStringPrepUtil.java:101)
    at org.jxmpp.jid.parts.Resourcepart.from(Resourcepart.java:91)
    at org.jivesoftware.smackx.bookmarks.Bookmarks.getConferenceStorage(Bookmarks.java:285)
    ...
```

2 of 2 new or added lines in 1 file covered. (100.0%)

16046 of 40999 relevant lines covered (39.14%)

0.39 hits per line