npm / cli / #2644

97%

latest: 97%

push

chore(refactor): refactor exit handler and tests

 * npm mock logger writes to npm.log.record too now
 * No more extra process.exit from within the process `exit` event handle.
 * No more `exit()` function.  Logic is rolled up into the exit handler.
 * Now there is only an exit handler and an exit event listener.
   `lib/utils/perf.js` was rolled up into npm.js itself.

Unfortunately the tests were written in such a way that any further
refactoring of the exit handler was going to require also rewriting the
tests.  Fortunately NOW the tests are interacting with the exit handler
in a way that shouldn't require them to be rewritten AGAIN if we change
the internals of the exit handler.

PR-URL: https://github.com/npm/cli/pull/3482
Credit: @wraithgar
Close: #3482
Reviewed-by: @nlf

3172 of 3261 branches covered (97.27%)

Branch coverage included in aggregate %.

87 of 87 new or added lines in 3 files covered. (100.0%)

5400 of 5543 relevant lines covered (97.42%)

26.04 hits per line