DarkaOnLine / L5-Swagger / 495

96%

master: 99%

push

travis-ci-com

Fix fatal during docs generation/respect "generate_always" flag (#385)

* Fix fatal during docs generation/respect "generate_always" flag

- fixes fatal when requested `$filePath` is invalid
  If non-existing doc is requested (e.g. https://example.com/docs/foo), an uncaught exception could be raised during `File::get()` call.
  Added a guard to prevent that.

- respect "generate_always" flag
  I think this was introduced back in https://github.com/DarkaOnLine/L5-Swagger/pull/172, presumably before `generate_always` config param was added.
  Imo with addition of `generate_always` this condition became slightly off - if user doesn't want the file to be generated on the fly (`generate_always=false`) l5-swagger shouldn't be ignoring that (by checking if `File::exists()`)

* add tests; fix lint error

3 of 3 new or added lines in 1 file covered. (100.0%)

280 of 293 relevant lines covered (95.56%)

14.01 hits per line