• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

wikimedia / parsoid / 776
85%

Build:
DEFAULT BRANCH: master
Ran 11 Nov 2015 07:56AM UTC
Jobs 4
Files 73
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
776

push

travis-ci

subbuss
T118367: Kill dead code + fix bad perf in pathological scenarios.

This code was added in fd0aefc3 (Aug 3, 2012) in the very
first draft of the template encapsulation code when nothing
but the very outlines of this technique had been dreamt up.

This code was seemlingly added to deal with fostered content from
tables (suprise!). But, given how our template wrapping works,
about tags are only assigned to the start/end meta tags and
nothing else in between. So, there was no way that a table
could exist with an about-id found on transclusion meta tags.

You can verify this by examining code in tt/TemplateHandler.js
and/or by running this:
echo "{{echo|a\n\nb\n\ncr\n\nd}}" | node parse --dump dom:pre-encap
and noticing that none of the p-tags there have an about id.

So, this code has always (or at least since almost the very
beginning) been dead, and only served to make parsing slow in
pathological cases as in the bug report.

With this dead code removed, that page parses in 17s.

Change-Id: I056169ada

12640 of 15045 relevant lines covered (84.01%)

86155.09 hits per line

Jobs
ID Job ID Ran Files Coverage
1 776.1 11 Nov 2015 07:59AM UTC 0
84.01
Travis Job 776.1
2 776.2 11 Nov 2015 07:56AM UTC 0
84.01
Travis Job 776.2
3 776.3 11 Nov 2015 07:57AM UTC 0
83.98
Travis Job 776.3
4 776.4 11 Nov 2015 08:01AM UTC 0
83.98
Travis Job 776.4
Source Files on build 776
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #776
  • 392e25eb on github
  • Prev Build on master (#775)
  • Next Build on master (#777)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc