npm / cli / #2526

97%

latest: 97%

push

chore(refactor): refactor exit handler and tests

 * npm mock logger writes to npm.log.record too now
 * No more extra process.exit from within the process `exit` event handle.
 * No more calling `process.exit()` at all. Which also means:
 * No more `stdout.write('')` before exiting
 * No more `exit()` function.  Logic is rolled up into the exit handler.
 * Now there is only an exit handler and an exit event listener.
   `lib/utils/perf.js` was rolled up into npm.js itself.

Unfortunately the tests were written in such a way that any further
refactoring of the exit handler was going to require also rewriting the
tests.  Fortunately NOW the tests are interacting with the exit handler
in a way that shouldn't require them to be rewritten AGAIN if we change
the internals of the exit handler.

3102 of 3191 branches covered (97.21%)

Branch coverage included in aggregate %.

87 of 87 new or added lines in 2 files covered. (100.0%)

5274 of 5417 relevant lines covered (97.36%)

25.85 hits per line