3743

Ran 07 Nov 2015 05:40PM UTC

Jobs 6

Files 2048

Run time 31min

Badge

Embed ▾

pending completion

Build # 3743

Build Type

Pull #1164

travis-ci

Committed by

andreww

Commit Message

Avoid multiple import of HAS_GEOGRAPHICLIB in test_tau

The reason we needed three imports of HAS_GEOGRAPHICLIB
in test_tau.py is that:

     from geodetics import HAS_GEOGRAPHICLIB
     if HAS_GEOGRAPHICLIB:
         ...

is not the same as:

     import geodetics
     if geodetics.HAS_GEOGRAPHICLIB
         ...

do different things. Using the second form means that
we can update HAS_GEOGRAPHICLIB in geodetics and have
the value change when accessed elsewhere. This patch
changes to the second form, saving multiple importing,
setting and resetting of HAS_GEOGRAPHICLIB.

geodetics could reasonably provide a context manager
(so you could test "with geodetics.nogeographiclib():",
or something) - but this seems like overkill for tests
in one file. I think this approach is probably the cleanest
we will find without adding such a feature.

Pull Request Pull Request #1164: Add get_..._geo to taup

Run Details

241315 of 280100 relevant lines covered (86.15%)

0.86 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3743.1 (PYTHON_VERSION=2.7)	07 Nov 2015 05:40PM UTC	341	86.34	Travis Job 3743.1
2	3743.2 (PYTHON_VERSION=3.3)	07 Nov 2015 05:53PM UTC	343	85.91	Travis Job 3743.2
3	3743.3 (PYTHON_VERSION=3.4)	07 Nov 2015 05:57PM UTC	341	86.13	Travis Job 3743.3
4	3743.4 (PYTHON_VERSION=3.5)	07 Nov 2015 05:53PM UTC	341	86.14	Travis Job 3743.4
5	3743.5 (PYTHON_VERSION=2.7)	07 Nov 2015 05:46PM UTC	341	86.31	Travis Job 3743.5
6	3743.6 (PYTHON_VERSION=3.5)	07 Nov 2015 06:10PM UTC	341	86.09	Travis Job 3743.6

Source Files on build 3743

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

obspy / obspy / 3743

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3743

obspy / obspy / 3743

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3743

README BADGES
x