462
100%
master: 100%

Ran 23 Jun 2021 05:26AM UTC

Jobs 1

Files 39

Run time 2s

Badge

Embed ▾

pending completion

Build # 462

Build Type

push

travis-ci-com

Committed by

rohanpm

Commit Message

koji: avoid some duplicate logs

In some error cases, a pattern was being used here like this:

- make an error message
- log the message as an ERROR
- raise exception with same message

The idea behind it is that, when raising the exception, we don't know
if anyone's going to catch it and log appropriately. If they don't,
then we may have created a situation we can't debug, and we'll surely
wish we had added that log message.

However, if the exception *is* caught and logged then this ends up with
duplicate messages.

Based on testing with Pub, the "duplicate message" case is more common,
so let's stop doing that and just raise the exception without logging an
error. We can still log as DEBUG, which will not show the message by
default but still gives us a way to enable the messages if needed.

Run Details

1421 of 1421 relevant lines covered (100.0%)

1.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	462.3 (TOX_ENV=cov-travis DEPLOY=1)	23 Jun 2021 05:26AM UTC	0	100.0	Travis Job 462.3

Source Files on build 462

Detailed source file information is not available for this build.

release-engineering / pushsource / 462
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 462

release-engineering / pushsource / 462 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 462

release-engineering / pushsource / 462
100%
master: 100%

README BADGES
x