npm / cli / #2173

97%

latest: 97%

push

fix: set audit exit code properly

When running 'npm audit', we properly exited correctly with the
appropriate exitCode based on the audit level config and the report
results.

However, when going through the reifyFinish() function (as we do for
'npm audit fix'), we were not setting that properly if the auditLevel
was not set.

Furthermore, if the auditLevel WAS set, we were setting the exit code to
non-zero for *other* reify commands (install, update, etc.), where the
audit information should be strictly advisory.

When --json and --loglevel=silent were set, the exitCode was never being
set properly.

This fixes all these problems.

PR-URL: https://github.com/npm/cli/pull/3311
Credit: @isaacs
Close: #3311
Reviewed-by: @wraithgar

3096 of 3203 branches covered (96.66%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

5279 of 5442 relevant lines covered (97.0%)

24.31 hits per line