245
99%

Ran 29 Oct 2015 10:57AM UTC

Jobs 5

Files 13

Run time 2min

Badge

Embed ▾

pending completion

Build # 245

Build Type

Pull #38

travis-ci

Committed by Gustav Munkby

Commit Message

Drain all in-flight socket writes on reactor close

The draining is a simple loop that tries to drain all the sockets until
all write buffers are empty. Technically, this only flushes the
application buffers, and there is no guarantee that the kernel and
network actually manages to get the bytes to the other side.

The draining is done with a timeout (which is currently hard-coded),
and in the event that draining fails, the reactor stop will also fail,
but all the existing shutdown logic will still be performed.

In order to not have to make the drain call conditional, the unblocker
and the acceptors implement drain methods. For the acceptor, the
distinction between drain and close doesn't make any sense, so in this
case it is just a simple alias. While the unblocker shouldn't be needed
during the drain, I wasn't 100% sure that is would be safe, so there
drain does nothing.

Pull Request Pull Request #38:

Run Details

2692 of 2698 relevant lines covered (99.78%)

18120.77 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	245.1 (1.9.3)	29 Oct 2015 10:57AM UTC	12	98.77	Travis Job 245.1
2	245.2 (2.0.0)	29 Oct 2015 10:57AM UTC	12	99.1	Travis Job 245.2
3	245.3 (2.1.1)	29 Oct 2015 10:58AM UTC	12	99.1	Travis Job 245.3
4	245.4 (jruby)	29 Oct 2015 10:58AM UTC	13	98.66	Travis Job 245.4
5	245.5 (jruby-head)	29 Oct 2015 10:59AM UTC	13	0.0	Travis Job 245.5

Source Files on build 245

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

iconara / ione / 245
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 245

iconara / ione / 245 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 245

iconara / ione / 245
99%

README BADGES
x