3424
63%

Ran 26 Oct 2015 03:13PM UTC

Jobs 1

Files 94

Run time 100838min

Badge

Embed ▾

pending completion

Build # 3424

Build Type

Pull #1296

travis-ci

Committed by

vincentbernat

Commit Message

libmachine: check state before returning GetURL() result

The new integration tests check if `env` and `url` return an error when
the machine is stopped. Currently, only virtualbox driver checks
that. Most drivers can return an URL without a problem while the machine
is not running.

We delegate the task of checking if the machine is running to libmachine
instead. libmachine will check the state and if the machine is not
running will return an empty string but no error. This is consistent
with what is expected in other parts of the code but may break some
drivers.

Tested with the exoscale driver.

Signed-off-by: Vincent Bernat <Vincent.Bernat@exoscale.ch>

Pull Request Pull Request #1296: libmachine: check state before returning GetURL() result

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

2974 of 11181 relevant lines covered (26.6%)

0.27 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
8	3.41	-0.21%	libmachine/host/host.go

Uncovered Existing Lines

Lines	Coverage	∆	File
2	86.67	0.0%	libmachine/provision/os_release.go
3	0.0	0.0%	commands/start.go
3	76.92	-23.08%	libmachine/provision/centos.go
3	0.0	0.0%	commands/restart.go
3	83.33	20.37%	drivers/virtualbox/disk.go
4	60.0	60.0%	commands/url.go
6	0.0	0.0%	commands/regeneratecerts.go
6	0.0	0.0%	commands/config.go
6	0.0	0.0%	commands/status.go
7	69.57	69.57%	drivers/virtualbox/virtualbox_linux.go
7	50.0	50.0%	commands/rm.go
8	65.38	18.33%	drivers/virtualbox/vm.go
9	33.96	28.08%	drivers/virtualbox/vbm.go
9	0.0	0.0%	commands/inspect.go
9	13.04	-1.24%	libmachine/provision/provisioner.go
9	0.0	0.0%	commands/ssh.go
11	0.0	0.0%	commands/active.go
12	68.94	16.16%	commands/ls.go
12	73.49	27.52%	libmachine/host/migrate.go
13	0.0	0.0%	libmachine/provision/configure_swarm.go
13	25.0	1.92%	libmachine/drivers/base.go
15	7.32	0.0%	libmachine/provision/generic.go
16	38.55	0.0%	libmachine/mcnutils/utils.go
16	23.19	-0.34%	libmachine/provision/boot2docker.go
16	46.7	41.58%	drivers/virtualbox/network.go
18	5.81	0.96%	libmachine/provision/coreos.go
19	3.41	-0.21%	libmachine/host/host.go
24	4.55	1.36%	libmachine/provision/debian.go
25	64.07	47.15%	commands/env.go
27	4.81	1.36%	libmachine/provision/arch.go
29	44.44	-1.98%	libmachine/drivers/plugin/localbinary/plugin.go
30	7.14	-0.22%	libmachine/provision/utils.go
34	48.18	5.32%	libmachine/persist/filestore.go
37	3.21	-0.11%	libmachine/provision/rancheros.go
38	47.37	6.74%	commands/scp.go
41	40.6	11.9%	commands/commands.go
42	6.25	-0.38%	libmachine/provision/suse.go
54	13.59	-2.6%	libmachine/provision/redhat.go
54	3.7	-0.02%	commands/create.go
55	44.54	44.54%	drivers/google/google.go
55	39.73	23.65%	drivers/softlayer/driver.go
63	2.51	-0.07%	drivers/google/compute_util.go
68	48.29	7.08%	libmachine/mcnutils/b2d.go
70	37.65	2.16%	libmachine/cert/cert.go
99	36.17	18.32%	drivers/amazonec2/amazonec2.go
150	26.12	12.45%	drivers/virtualbox/virtualbox.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	3424.1	04 Jan 2016 03:52PM UTC	94	26.6	Travis Job 3424.1

Source Files on build 3424

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

docker / machine / 3424
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3424

docker / machine / 3424 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3424

docker / machine / 3424
63%

README BADGES
x