7055
79%
master: 79%

Ran 06 May 2021 08:19PM UTC

Jobs 2

Files 301

Run time 5min

Badge

Embed ▾

Committed 06 May 2021 08:10PM UTC coverage: 78.913% (-0.08%) from 78.988%

Build # 7055

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Backport fix node selector query split-response to 0.12 (#2242) (#2245)

The DataStore query that returns the list of agent node selectors is currently sorted by row ID, which under certain circumstances can cause it to split the selectors for a given agent ID into more than one entry in the aggregated results. The only caller is the full entry cache, which does not handle this well, which can cause agents to not be associated with a node alias whose selectors end up spanning these splits.

This change fixes the query to order by SPIFFE ID instead of row ID so that the selectors for a given agent are grouped together and returned in a single entry in the aggregated results.

It also aggregates the results differently such that the order does not matter for correctness so that the code is resilient against a similar bug in the future.

Co-Authored-By: Andrew Harding <aharding@vmware.com>
Signed-off-by: Jonathan Oddy <jonathan.oddy@transferwise.com>

Run Details

24329 of 30830 relevant lines covered (78.91%)

34.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	7055.2	06 May 2021 08:23PM UTC	0	78.97	Travis Job 7055.2
3	7055.3	06 May 2021 08:19PM UTC	0	78.91	Travis Job 7055.3

Source Files on build 7055

Detailed source file information is not available for this build.

spiffe / spire / 7055
79%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7055

spiffe / spire / 7055 79% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7055

spiffe / spire / 7055
79%
master: 79%

README BADGES
x