npm / arborist / #958

push

fix(add): save packages in the right place

Right now where we end up saving a dep is not very well coupled to where
the user requested it.  We are inferring more than we are checking for
intention.  This moves us to more heavily lean on the `saveType` if
given when adding a package into the dependencies.

We also were not consistently inferring the saveType.  There was code in
two places trying to do this, and either place used slightly different
logic. This moves the logic into one place.

Finally, we are more consistently making certain dependency types
mutually exclusive, for instance dependencies and devDependencies.

3010 of 3029 branches covered (99.37%)

Branch coverage included in aggregate %.

4050 of 4061 relevant lines covered (99.73%)

562.24 hits per line