mmabey / fhirdatetime / 41

63%

push

travis-ci-com

Too many problems with private properties

When I attempted to copy over portions of the datetime.datetime class
piecemeal, I ultimately had the problem that there were too many methods
that accessed the private attributes of the original datetime class. For
reasons touched on in the commit message for d7036c1, those private
attributes are critical and not accessible to inheriting types.

So, instead of having FhirDateTime inherit directly from datetime, I'm
now using multiple inheritance (hey, it was the best solution that still
allowed for `isinstance(fhir_date_time, datetime.datetime)` to still
return `True`), where a customized version of datetime is the primary
parent class. The only customizations done are to include all methods
from the std lib's datetime and date classes and put them in one place,
plus added an `__init__()` function that blindly stores the private
attributes' values (meaning without any validation). Plus some
formatting from black, haha.

638 of 638 new or added lines in 2 files covered. (100.0%)

492 of 855 relevant lines covered (57.54%)

1.15 hits per line