screwdriver-cd / screwdriver / #1492

95%

push

screwdriver

fix: refactor triggerNextJobs function (#2374)

* fix: refactor triggerNextJobs function

* remove no external logic flow
refactror fillparentbulds
refactor get finished bulds
* fix: remove removeDownstreamBuilds and refactor getFinishedBuilds
fetching by groupEventId should be enough to grab the latest finished builds
* further refactoring before moving to join job
* fix: add back getParallelBuilds
* move trigerNextJob inside for easy review
* fix: move into createOrRunNextBuild, remove streamline fn arguments
* remove externalJoin flag
* remove triggerExternalJobsWithNoJoin and let default logic handle this case
* refactor to separate out external next jobs & internal next jobs
* fix workflow when restart of remote join job
* add joid id to join object
* always copy test results to artifacts dir
* refactor createinternalbuild function
* more code cleanup and fixing tests
* remove external join test cases from old flow, since it has incomplete workflow graph data
* fix more tests, remove duplicate ones from old join flow since there are covered in new join flow
* add js docs and remove externalJoin from config
* run coverage on teardown
* logic for restart join job trigger
1. create external event with startFrom as remote trigger syntax
2. manually start each join job
* refactor parentbuilds fill flow.
* use lodash.merge instead of deepmerge
* eslint fix
* use lodash.mergewith instead of loadash.merge

1295 of 1383 branches covered (93.64%)

Branch coverage included in aggregate %.

123 of 123 new or added lines in 2 files covered. (100.0%)

3524 of 3623 relevant lines covered (97.27%)

84.73 hits per line