openlcb / OpenLCB_Java / 450

71%

push

travis-ci

Warn the user upon closing with unsaved changes (#178)

Adds a warning dialog when a CDI window is closed with unsaved settings.

Misc changes:
- cleans up how the save button enabled/disabled is handled
- makes the collapsible panel header be bold font
- cleans up some whitespace

Code contributed by Pete Cressman <petecressman>

===

* Implement closing dialog to let user go back and write changes. Remind
user to save panel when sensor or turnout is made. Enable/disable 'Write
All' button (formerly Save changes button) according to whether saves
are needed. Suppress 'end update' message when no changes have been
made. Fix create sensor/turnout titled panel. Set Collapse panels title
to bold.  Set default directory for backup and restore to user's choice
of file location in preferences.

* Format with Eclipse formatter.

* Remove tab characters.

* Restore suggested file name include nodeID not nodeName.

* pre-selected file for backup/restore changed back to
"config."+rep.getRemoteNodeAsString()+".txt"

* Made suggested changes.

* - Adds missing comments. Removes draft comments.
- renames _saveNeeded to _unsavedRestore because that describes the semantics of the variable better and makes the code more readable.
- Implements a limit of how many "...is not saved" messages we put into the confirmation dialog.
- Makes the confirmation dialog buttons more clear what they do.

* Refactors all accesses to the save changes button to a helper method.

* reverts getName because the behavior is better when we have null.

* replaces chaeckForSave with notifyTabColorRefresh to allow de-duplicating these calls when many entries are saved at once.

Co-authored-by: petecressman <pete_cressman@sbcglobal.net>

151 of 151 new or added lines in 2 files covered. (100.0%)

5577 of 7866 relevant lines covered (70.9%)

0.71 hits per line