jonasbn / perl-workflow / 281

93%

push

travis-ci

Use the instance class as the logging category (#69)

* Use the instance class as the logging caterogy

Per Log::Log4perl's recommendation (see https://metacpan.org/pod/Log::Log4perl#Pitfalls-with-Categories),
use the class of the instance as the category for purposes of logging -- where possible.

This allows much better control over which parts of the application do
logging and which parts don't.

* Incorporate suggested formatting change from review

Co-authored-by: Jonas Brømsø <jonasbn@users.noreply.github.com>

* Fix bug found during review by @jonasbn

The Id generating classes referred to the `log` method, which neither
defined. This commit defines a `log` accessor for the attribute by
the same name.

Incidentally align the implementations of `SequenceId` and
`AutoGeneratedId` in that they both document their properties,
both define a `new` method and both define a `log` attribute now.

Co-authored-by: Jonas Brømsø <jonasbn@users.noreply.github.com>

170 of 170 new or added lines in 17 files covered. (100.0%)

1542 of 1870 relevant lines covered (82.46%)

33.42 hits per line