8455
67%
master: 97%

Ran 07 Oct 2015 03:07PM UTC

Jobs 1

Files 85

Run time 2s

Badge

Embed ▾

pending completion

Build # 8455

Build Type

push

travis-ci

Committed by

nickstenning

Commit Message

Fix race for session data on startup

Several parts of the application require access to the session data
fetched from the server when rendering. On first page load we don't have
this data (something we can fix in the future by inlining the data with
the viewer HTML) and this resulted in a race between the session data
load triggered by `checkAuthentication` (in config/identity.js) and the
query sent to the server by `WidgetController`, which needs to know the
current focused group id.

Fix this by ensuring that the first load of session data is complete
before switching views -- achieved by adding an item to the list of
dependencies passed to `$routeProvider`.

This works, but results in multiple requests for session data in quick
succession, because `checkAuthentication` runs while the view is
loading. To resolve this problem, we add a straightforward TTL check to
the `session.load()` method, and only make a new request if the data is
more than 5m old.

Session data will be overwritten as normal whenever session mutating
methods (`session.login()`, `session.logout()`) etc. are called.

Fixes #2590.

Run Details

2387 of 3557 relevant lines covered (67.11%)

0.67 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	8455.1	07 Oct 2015 03:07PM UTC	0	67.11	Travis Job 8455.1

Source Files on build 8455

Detailed source file information is not available for this build.

hypothesis / h / 8455
67%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8455

hypothesis / h / 8455 67% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8455

hypothesis / h / 8455
67%
master: 97%

README BADGES
x