sybrenstuvel / python-rsa / 351

92%

master: 92%

push

travis-ci

Fix exception causes all over the codebase

The mistake is this: In some parts of the code, an exception is being
caught and replaced with a more user-friendly error. In these cases the
syntax `raise new_error from old_error` needs to be used.

Python's exception chaining means it shows not only the traceback of the
current exception, but that of the original exception (and possibly
more.) This is regardless of `raise from`. The usage of `raise from`
tells Python to put a more accurate message between the tracebacks.
Instead of this:

    During handling of the above exception, another exception occurred:

You'll get this:

    The above exception was the direct cause of the following exception:

The first is inaccurate, because it signifies a bug in the
exception-handling code itself, which is a separate situation than
wrapping an exception.

6 of 6 new or added lines in 3 files covered. (100.0%)

746 of 814 relevant lines covered (91.65%)

3.67 hits per line