stefanberger / libtpms / 1862

77%

push

travis-ci-com

tpm2: Sanitize values read from TPM state stream (Coverity)

Sanitize some of the values read from the TPM state stream.
All Coverity discoveries seem to be false positives.

Coverity doesn't like to see array_size being used in the loop even
though it was compared against ARRAY_SIZE() before. We solve this by
using ARRAY_SIZE() as the loop limit now rather than array size.

Compare seed.b.size against PRIMARY_SEED_SIZE even though this is
already being done in TPM2B_Unmarshal().

The num_bytes parameter is sanitized via a comparison involving a
sum over a sum of values, but Coverity doesn't seem to detect this.
Then we have to use it as a loop limit. I don't see another way.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

19 of 19 new or added lines in 1 file covered. (100.0%)

28932 of 37388 relevant lines covered (77.38%)

88706.25 hits per line