cdimascio / express-openapi-validator / 2442

91%

push

travis-ci

Fix Mutation of API Spec (#537)

* test: Add Failing Test Case for Issue 535.

Add failing test case for
https://github.com/cdimascio/express-openapi-validator/issues/535.

The problem manifests itself when calling `middleware()` with an object
multiple times, as the object itself is mutated which might cause errors
on subsequent calls.

In this specific example, the parameters for GET /ping/{value} are
modified in such a way that a second call will cause a validation error.
This happens in `preprocessPathLevelParameters`.

* fix: Clone API Spec to avoid Mutation of Parameter

Clone the API specification passed to the `middleware()` function. This
avoids mutating the `apiSpec` parameter passed to that function, which
can lead to unexpected behaviour.

Fixes https://github.com/cdimascio/express-openapi-validator/issues/535.

1041 of 1217 branches covered (85.54%)

Branch coverage included in aggregate %.

1273 of 1345 relevant lines covered (94.65%)

397.02 hits per line