3763
97%

Ran 09 Feb 2021 05:51PM CUT

Jobs 6

Files 106

Run time 3min

Badge

Embed ▾

pending completion

Build # 3763

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix return value of `Customer#delete_discount` (#964)

`Customer#delete_discount` has been broken for some time in that it
tries to re-initialize `self` (which is a customer) with a received
discount response. This is incorrect and leads to various problems.

Here, we redefine the return value of `delete_discount` as a discount,
and have it no longer mutate the object on which is was called. We add a
comment as well just to help flag some of the behavior which could
potentially be confusing.

Fixes #963.

Run Details

2075 of 2145 relevant lines covered (96.74%)

2498.9 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3763.1 (2.3, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:51PM CUT	96.68	Travis Job 3763.1
2	3763.2 (2.4, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:51PM CUT	96.68	Travis Job 3763.2
3	3763.3 (2.5, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:51PM CUT	96.69	Travis Job 3763.3
4	3763.4 (2.6, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:51PM CUT	96.76	Travis Job 3763.4
5	3763.5 (2.7, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:51PM CUT	96.76	Travis Job 3763.5
6	3763.6 (jruby-9.2.7.0, STRIPE_MOCK_VERSION=0.101.0)	09 Feb 2021 05:53PM CUT	0.0	Travis Job 3763.6

Source Files on build 3763

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
58.62	lib/stripe/error_object.rb	94	29	17	12	5.0
60.0	lib/stripe/resources/bitcoin_receiver.rb	24	10	6	4	5.0
73.33	lib/stripe/resources/card.rb	38	15	11	4	5.0
81.82	lib/stripe/resources/application_fee_refund.rb	30	11	9	2	5.0
81.82	lib/stripe/resources/reversal.rb	29	11	9	2	5.0
83.33	lib/stripe/resources/bitcoin_transaction.rb	15	6	5	1	5.0
88.24	lib/stripe/resources/bank_account.rb	43	17	15	2	6.0
90.91	lib/stripe/resources/transfer.rb	27	11	10	1	5.0
91.53	lib/stripe/connection_manager.rb	162	59	54	5	2084.0
91.67	lib/stripe/singleton_api_resource.rb	26	12	11	1	5.0

96.76
lib/

stripe / stripe-ruby / 3763
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3763

stripe / stripe-ruby / 3763 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3763

stripe / stripe-ruby / 3763
97%

README BADGES
x