3761
97%
master: 97%

Ran 08 Feb 2021 10:08PM UTC

Jobs 6

Files 106

Run time 3min

Badge

Embed ▾

pending completion

Build # 3761

Build Type

push

travis-ci

Committed by

brandur

Commit Message

Fix return value of `Customer#delete_discount`

`Customer#delete_discount` has been broken for some time in that it
tries to re-initialize `self` (which is a customer) with a received
discount response. This is incorrect and leads to various problems.

Here, we redefine the return value of `delete_discount` as a discount,
and have it no longer mutate the object on which is was called. We add a
comment as well just to help flag some of the behavior which could
potentially be confusing.

Fixes #963.

Run Details

2075 of 2145 relevant lines covered (96.74%)

2498.9 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3761.1 (2.3, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:08PM UTC	96.68	Travis Job 3761.1
2	3761.2 (2.4, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:08PM UTC	96.68	Travis Job 3761.2
3	3761.3 (2.5, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:08PM UTC	96.69	Travis Job 3761.3
4	3761.4 (2.6, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:08PM UTC	96.76	Travis Job 3761.4
5	3761.5 (2.7, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:08PM UTC	96.76	Travis Job 3761.5
6	3761.6 (jruby-9.2.7.0, STRIPE_MOCK_VERSION=0.101.0)	08 Feb 2021 10:10PM UTC	0.0	Travis Job 3761.6

Source Files on build 3761

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3761
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3761

stripe / stripe-ruby / 3761 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3761

stripe / stripe-ruby / 3761
97%
master: 97%

README BADGES
x