mapbox / rasterio / 4947

96%

push

travis-ci-com

Avoid extra array allocations in copyto functions (#2101)

* Use inplace min/max to avoid array allocation.

In microbenchmark tests, the inplace seems to be slightly faster.

* Allocate a single array for a mask and use in-place operations

This is far more efficient that the multiple new arrays allocated by the
original function.

* Fix accidentally renamed function.

* Allow first operation to allocate and return new array

It looks cleaner to me and turns out to be just a little bit faster than
calling empty_like.

* Always use incoming input mask.

* Allocate mask array explicitly again.

* Factor out copy methods. Resolve method once.

* Format error message with list.

* Use much faster nan check

We can use a much faster scalar nan check.

1239 of 1346 branches covered (92.05%)

33 of 33 new or added lines in 1 file covered. (100.0%)

3434 of 3563 relevant lines covered (96.38%)

7.71 hits per line