camptocamp / facterdb / 428

100%

push

travis-ci

<a href="https://github.com/camptocamp/facterdb/commit/<a class=hub.com/camptocamp/facterdb/commit/<a class="double-link" href="https://git"><a class=hub.com/camptocamp/facterdb/commit/1442bc4913c9a1dedb1d6f31a98bf2a5cb6873ea">1442bc491<a href="https://github.com/camptocamp/facterdb/commit/1442bc4913c9a1dedb1d6f31a98bf2a5cb6873ea">&lt;a href=&quot;https://github.com/camptocamp/facterdb/commit/1442bc4913c9a1dedb1d6f31a98bf2a5cb6873ea&quot;&gt;&amp;quot;&amp;gt;Remove `clientX` facts from solaris factsets

These are facts normally set by the puppet agent.
https://puppet.com/docs/puppet/5.5/lang_facts_and_builtin_vars.html#puppet-agent-facts

`clientversion`, `clientcert` have dedicated handling in rspec-puppet to
set them correctly.
https://github.com/rodjek/rspec-puppet/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/camptocamp/facterdb/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/camptocamp/facterdb/commit/f2e05f4a480a0d859121f5cab2dc5a70eb82d10a&quot;&gt;f2e05f4a4&lt;/a&gt;&quot;&gt;f2e05f4a4&lt;/a&gt;&lt;a href=&quot;https://github.com/camptocamp/facterdb/commit/1442bc4913c9a1dedb1d6f31a98bf2a5cb6873ea&quot;&gt;/lib/rspec-puppet/support.rb#L245

I found that the hardcoded values leads to a mismatch between the
puppet version being tested and the value of `clientversion`.

Specifically, it caused testing a module using concat with Puppet 5 to
explode [here](https://github.com/puppetlabs/puppetlabs-concat/blob/</a><a class="double-link" href="https://github.com/camptocamp/facterdb/commit/<a class="double-link" href="https://github.com/camptocamp/facterdb/commit/b98de457a364908417b454f906a3ad5224bb04b9">b98de457a</a>">b98de457a</a>/manifests/fragment.pp#L47)
(`Deferred` is not a valid type until Puppet 6).

69 of 69 relevant lines covered (100.0%)

22000.57 hits per line