• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

cryptocoinjs / pbkdf2-sha256 / 13
100%

Build:
DEFAULT BRANCH: master
Ran 28 Sep 2015 12:27PM UTC
Jobs 2
Files 1
Run time 19s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
13

Pull #2

travis-ci

dabura667
Handle all strings as utf-8 bytes (Buffers)

Notice how these are different.
```javascript
> c.createHmac('sha256', 'あ').update(buf).digest()
<SlowBuffer 07 33 71 74 91 d4 51 b0 e5 9b eb d9 a0 32 a6 69 34 c4 c9 5a 54 f6 dd ea da 50 28 f7 10 f0 61 35>
> c.createHmac('sha256', new Buffer('あ')).update(buf).digest()
<SlowBuffer 3e 2b 7b 53 31 04 3d 8a 24 ab bd 88 3a 61 6a 37 1d 28 ab 28 8a b5 81 e2 ad 17 26 28 19 bd 1a bb>
> c.createHmac('sha256', new Buffer('あ','utf8')).update(buf).digest()
<SlowBuffer 3e 2b 7b 53 31 04 3d 8a 24 ab bd 88 3a 61 6a 37 1d 28 ab 28 8a b5 81 e2 ad 17 26 28 19 bd 1a bb>
>
```
Would handling everything as utf8 go against pbkdf2 spec?
Pull Request #2: Handle all strings as utf-8 bytes (Buffers)

1 of 1 new or added line in 1 file covered. (100.0%)

28 of 28 relevant lines covered (100.0%)

433333.29 hits per line

Jobs
ID Job ID Ran Files Coverage
2 13.2 (TEST_SUITE=coveralls) 28 Sep 2015 12:28PM UTC 0
100.0
Travis Job 13.2
4 13.4 (TEST_SUITE=coveralls) 28 Sep 2015 12:27PM UTC 0
100.0
Travis Job 13.4
Source Files on build 13
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #13
  • Pull Request #2
  • PR Base - master (#11)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc