1920
96%

Ran 28 Sep 2015 10:55AM UTC

Jobs 22

Files 164

Run time 123min

Badge

Embed ▾

pending completion

Build # 1920

Build Type

Pull #2412

travis-ci

Committed by Megha

Commit Message

Change multiselect cache structure

The existing structure used an Object as a cache where the keys are the
values of option elements, and values are the HTML content of the option
elements. In Javascript, if a numeric value in the form of a string is
assigned as a key, it gets converted to an integer. Optimization
routines would then order the object to ensure faster access to
elements. For example:

cache = {}
cache['2'] = "two"
cache['1'] = "one"
console.log(cache[2])  #=> "two"
console.log(cache[1])  #=> "one"
console.log(cache)     #=> {1: "one", 2: "two"}

Note the coercion of strings to ints above. This messes with the
ordering of multiselect options list whenever there is a user input. To
avoid this from happening, the keys need to have a string that can't be
coerced automatically, and then preserve the value of the option
element.

I chose to use an object that stores the option value and the option
HTML as the value of the cache and a string of the format 'o_<option
value>' as the key. This ensures that the insertion order is preserved.
This is the new structure:

cache = {
  'o_271': { id: 271, value: 'CartItem #271'},
  'o_270': { id: 270, value: 'CartItem #270}'
}

Pull Request Pull Request #2412:

Run Details

4336 of 4580 relevant lines covered (94.67%)

44628.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1920.1 (1.9.3, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 10:57AM UTC	120	91.37	Travis Job 1920.1
2	1920.2 (2.0.0, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 10:55AM UTC	120	91.37	Travis Job 1920.2
3	1920.3 (2.1, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 10:57AM UTC	120	91.71	Travis Job 1920.3
4	1920.4 (2.2, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 12:58PM UTC	120	91.71	Travis Job 1920.4
5	1920.5 (rbx-2, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:10AM UTC	133	97.62	Travis Job 1920.5
6	1920.6 (ruby-head, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 10:58AM UTC	120	91.37	Travis Job 1920.6
7	1920.7 (1.9.3, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:00AM UTC	121	92.16	Travis Job 1920.7
8	1920.8 (2.0.0, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:00AM UTC	121	92.16	Travis Job 1920.8
9	1920.9 (2.1, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:00AM UTC	121	92.56	Travis Job 1920.9
10	1920.10 (2.2, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:00AM UTC	121	92.5	Travis Job 1920.10
11	1920.11 (rbx-2, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:18AM UTC	138	97.79	Travis Job 1920.11
12	1920.12 (ruby-head, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:04AM UTC	121	92.16	Travis Job 1920.12
13	1920.13 (2.2, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.0.gemfile)	28 Sep 2015 11:03AM UTC	121	92.41	Travis Job 1920.13
14	1920.14 (2.2, CI_ORM=mongoid, gemfiles/rails_4.0.gemfile)	28 Sep 2015 11:03AM UTC	120	91.77	Travis Job 1920.14
15	1920.15 (2.2, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.1.gemfile)	28 Sep 2015 11:05AM UTC	121	92.56	Travis Job 1920.15
16	1920.16 (2.2, CI_ORM=mongoid, gemfiles/rails_4.1.gemfile)	28 Sep 2015 11:06AM UTC	120	91.77	Travis Job 1920.16
17	1920.17 (2.2, CI_ORM=active_record CI_DB_ADAPTER=mysql2, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:06AM UTC	121	92.56	Travis Job 1920.17
18	1920.18 (2.2, CI_ORM=active_record CI_DB_ADAPTER=postgresql CI_DB_USERNAME=postgres, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:08AM UTC	121	92.56	Travis Job 1920.18
19	1920.19 (jruby-19mode, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:11AM UTC	157	92.01	Travis Job 1920.19
20	1920.20 (jruby-19mode, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:11AM UTC	161	92.69	Travis Job 1920.20
21	1920.21 (jruby-head, CI_ORM=mongoid, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:16AM UTC	156	91.73	Travis Job 1920.21
22	1920.22 (jruby-head, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_4.2.gemfile)	28 Sep 2015 11:19AM UTC	160	92.52	Travis Job 1920.22

Source Files on build 1920

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

sferik / rails_admin / 1920
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1920

sferik / rails_admin / 1920 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1920

sferik / rails_admin / 1920
96%

README BADGES
x