209620
78%

Ran 04 Feb 2021 06:30AM UTC

Jobs 1

Files 695

Run time 3min

Badge

Embed ▾

Committed 04 Feb 2021 06:30AM UTC coverage: 78.716% (+0.003%) from 78.713%

Build # 209620

Build Type

push

CI-PR build

Committed by GitHub

Commit Message

Fix deliveryMode.ExpectReplies for skills. (#5142)

* Fixes deliveryMode.ExpectReplies for skills.

When callling /api/messages the return type is always a InvokeResponse<T> data structure.

When a skill receives an activity with deliveryMode=expectReplies, it the botframeworkAdapter caches responses and returns it as a InvokeReponse<ExpectedReplies> meaning
```
{
   status: status code
   body: { // type expectedReplies
      activities: [... ]
    }
}
```
This is correct behavior.

The bug is that the BotFrameworkHttpClient code is interpreting the body of the response as ExpectedReplies instead of InvokeResponse<ExpectedReplies>

The properties don't align and hence not processed.

The unit tests test both sides independently but with mismatched assumptions, so only when e2e is used it doesn't work. (classic metric vs english measurement situation).

This changes client to do correc thing and aligns unit tests to same assumptions as the bot framework adapter class.

* more accurate

Coverage Stats

17630 of 22397 relevant lines covered (78.72%)

0.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	209620.2	04 Feb 2021 06:32AM UTC	0	78.72

Source Files on build 209620

Detailed source file information is not available for this build.

microsoft / botbuilder-dotnet / 209620
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 209620

microsoft / botbuilder-dotnet / 209620 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 209620

microsoft / botbuilder-dotnet / 209620
78%

README BADGES
x