reactstrap / reactstrap / 3605

93%

push

travis-ci

feat(Dropdown): add support for listbox or menu role (#2077)

* feat(Dropdown, DropdownMenu, DropdownToggle): allow Dropdown to have listbox or menu role

Dropdown Menu should allow for listbox or menu roles.  Before this commit, the Dropdown could only have the menu role.  After this commit, a user can add a menuRole property to the Dropdown component which will set a corresponding aria-haspopop property on the DropdownToggle, role property on the DropdownMenu, and role property on the Dropdown Items

* feat(Dropdown, DropdownMenu, DropdownToggle): simplify code and fix bugs

Address all code cleanlieness and backwards compatibility issues brought up in PR

* feat(Dropdown, DropdownContext, DropdownMenu, DropdownItem): refactor and fix a typo

Address all issues mentioned in PR review

Co-authored-by: Kyle Tsang <6854874+kyletsang@users.noreply.github.com>

1031 of 1197 branches covered (86.13%)

14 of 14 new or added lines in 4 files covered. (100.0%)

1673 of 1788 relevant lines covered (93.57%)

178.78 hits per line