• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

npm / arborist / #643

Build:
Build:
LAST BUILD BRANCH:
DEFAULT BRANCH: master
Ran 28 Jan 2021 07:47PM UTC
Jobs 1
Files 39
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
#643

push

isaacs
Prevent ERESOLVEs caused by loose root dep specs

Given the following dep graph:

```
root -> a@*, b@2
b -> PEER(a@1)
```

when we load the peerSet for `b@2`, we pull in the parent's
spec for that dependency, `a@*`.  This may result in adding `a@2` to the
tree, which conflicts with b's peer dependency.  However, `a@1` would
have _also_ satisfied the root's dependency and _not_ caused a conflict.

When there is no version that can be found to satisfy both dependencies,
then we use the parent's dependency and warn/crash as we would have
previously.  However, with this commit, we are more aggressively
deduplicating the parent/child dependency collision to avoid ERESOLVEs
that are unnecessary.

This increased deduplication results in a lot of churn in the test
snapshot, because it typically means getting an earlier or more
restrictive version of a shared peer dependency.

2737 of 2737 branches covered (100.0%)

Branch coverage included in aggregate %.

3747 of 3747 relevant lines covered (100.0%)

561.15 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #643.1 28 Jan 2021 07:47PM UTC 0
100.0
Source Files on build #643
Detailed source file information is not available for this build.
  • Back to Repo
  • cccd579b on github
  • Prev Build on
  • Next Build on
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc