206456
78%

Ran 27 Jan 2021 04:48AM UTC

Jobs 1

Files 689

Run time 3min

Badge

Embed ▾

Committed 27 Jan 2021 04:48AM UTC coverage: 78.531% (+0.04%) from 78.496%

Build # 206456

Build Type

push

CI-PR build

Committed by GitHub

Commit Message

Cyclical dialog graphs: Bug fixes and improvements in DialogSet, DialogManager and Type Loading (#5072)

* Cyclical dialog graphs: Bug fixes and improvements in DialogSet, DialogManager and Type Loading

- DialogSet: Telemetry client setter leading to StackOverflowExceptions on any cyclical dialog structure. Affects traditional component dialogs, coded adaptive dialgs and could affect declarative dialogs
- DialogManager: Recursive registration of dependencies, on cyclical dialog structures could lead to stackOverflowException
- Type loading: Cache DialogExpression instances to improve performance, fix debugger which requires a single instance for an id, and catch special cases that can break type loading of cyclical dialog structures

* DialogManager and DialogExpressionConverter: explicit string comparison

* Declarative: add test loading with AdaptiveDialog as type instead of Dialog

Coverage Stats

17298 of 22027 relevant lines covered (78.53%)

0.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	206456.2	27 Jan 2021 04:48AM UTC	0	78.53

Source Files on build 206456

Detailed source file information is not available for this build.

microsoft / botbuilder-dotnet / 206456
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 206456

microsoft / botbuilder-dotnet / 206456 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 206456

microsoft / botbuilder-dotnet / 206456
78%

README BADGES
x