10671
66%

Ran 27 Jan 2021 03:09AM UTC

Jobs 1

Files 944

Run time 3min

Badge

Embed ▾

pending completion

Build # 10671

Build Type

push

travis-ci

Committed by

nmathewson

Commit Message

Fix a subtle memory leak in test_exorport.c

This is a _subtle_ bug introduced by d1494d14, which resolved
connections that was allocated in the extorport/handshake test.  So
how did the connection get freed?  Our test was set up so that every
extorport connection would get the same ext_or_id.  Two connections
couldn't have the same ext_or_id, and if they did, one would get
freed.  This meant that the _next_ connection to be constructed in
the test would cause the previous connection to become closeable,
even if it hadn't been closeable before.

But when we applied d149d14, we stopped making it so our code
enforced this uniqueness, and thereby make it so we _weren't_
freeing this connection in the tests.

Closes #40260; bug not in any released version of Tor.

Run Details

52037 of 80669 relevant lines covered (64.51%)

36615.14 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
9	10671.9 (MAKEFLAGS="-k -j 2" HARDENING_OPTIONS="--enable-all-bugs-are-fatal --enable-expensive-hardening" ASCIIDOC_OPTIONS="--disable-asciidoc" RUST_VERSION="1.31.0" CHUTNEY_TOR_SANDBOX="0" CHUTNEY_MAKE="test-network-all" COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765")	27 Jan 2021 03:09AM UTC	0	64.51	Travis Job 10671.9

Source Files on build 10671

Detailed source file information is not available for this build.

torproject / tor / 10671
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10671

torproject / tor / 10671 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10671

torproject / tor / 10671
66%

README BADGES
x