• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jmoiron / sqlx / 192
74%

Build:
DEFAULT BRANCH: master
Ran 26 Jan 2021 01:04AM UTC
Jobs 3
Files 7
Run time 28s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Jan 2021 11:18PM UTC coverage: 73.71%. Remained the same
192

push

travis-ci

jmoiron
fixes #688

The changes in #635 changed the some of the output types of In to
pointers.  This takes less time but it also changed the types in the
output of In in a way that I think is more aggressive than I would have
preferred.  I'm also not 100% convinced that using pointers to types like
`int` and `string` would provide an overall performance benefit when you
factor in GC.

Despite that, timings did get worse:

pre-change:

```
BenchmarkIn-4                3136129               376 ns/op             272
B/op           4 allocs/op
BenchmarkIn1k-4                   171588              6602 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kInt-4                157549              7502 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kString-4             155502              7604 ns/op
19488 B/op             3 allocs/op
```

post-change:

```
BenchmarkIn-4                    3007132               396 ns/op
272 B/op               4 allocs/op
BenchmarkIn1k-4                   175978              6768 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kInt-4                120422             10125 ns/op
19488 B/op             3 allocs/op
BenchmarkIn1kString-4             108813             10755 ns/op
19488 B/op             3 allocs/op
```

I'd prefer to keep `[]int{..}` producing ints instead of `*int` even if
it means losing ~25% of perf on these special cased functions.

2 of 2 new or added lines in 1 file covered. (100.0%)

1200 of 1628 relevant lines covered (73.71%)

608.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 192.1 26 Jan 2021 01:04AM UTC 0
73.71
Travis Job 192.1
2 192.2 26 Jan 2021 01:04AM UTC 0
73.71
Travis Job 192.2
3 192.3 26 Jan 2021 01:05AM UTC 0
73.71
Travis Job 192.3
Source Files on build 192
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #192
  • 75a7ebf2 on github
  • Prev Build on master (#190)
  • Next Build on master (#194)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc