benmosher / eslint-plugin-import / 4291

94%

Build Type

push

travis-ci

Committed by Jordan Harband

Commit Message

[Fix] `extensions`/`no-cycle`/`no-extraneous-dependencies`: Correct module real path resolution

add real support of isAbsolute (windows + unix support)

importType refactoring: use the real resolved package path to check if external of internal, and not the name only like before: in case of monorepo, external modules are not under node_modules due to symlink but still out of the module.

correct tests node_modules dependencies to really provide teh package.json like in real usage

correct no-extraneous-dependencies rule: get the real name from the resolved package.json. If not aliased imports (alias/react for example) will not be correctly interpreted

change path import

add real support of isAbsolute (windows + unix support)

correct no-extraneous-dependencies rule: get the real name from the resolved package.json. If not aliased imports (alias/react for example) will not be correctly interpreted

even externals like "a/file.js" must not use extension.
only module names like 'module.js' and '@scope/module.js' are allowed

correct bad external definition: must be the folder path under the root of the module.
Here the module root is test folder, not cycles folder

Run Details

1639 of 1744 branches covered (93.98%)

2295 of 2345 relevant lines covered (97.87%)

2545.35 hits per line