ryansolid / solid / 931

91%

push

travis-ci-com

Change `sideEffects` from string to boolean (#312)

According to the specification of `sideEffects` which is a Webpack thing apparently, the `sideEffects` value should be either a boolean or an array of string (that represent the files operating side effects).
Although I doubt this is a deal breaker, a warning is occasionally thrown in ESBuild (via vite):
```build
 > node_modules/.pnpm/solid-meta@0.23.11_solid-js@0.23.11/node_modules/solid-meta/package.json: warning: The value for "sideEffects" must be a boolean or an array
    18 │   "sideEffects": "false",
       ╵   
```

767 of 909 branches covered (84.38%)

Branch coverage included in aggregate %.

997 of 1052 relevant lines covered (94.77%)

202969.51 hits per line