optimizely / javascript-sdk / 2665

78%

push

travis-ci-com

feat: Implement DecisionResponse in decision hierarchy (#640)

* Create DecisionResponse interface

* Refactor bucketer.bucket reasons and partially decision_service reasons

* Create class DecisionResponse instead of an interface

* Update getVariation and getVariationForFeature methods in decision service

* Update getForcedVariation method in decision service

* Clean up and start fixing decision_service tests

* Update decision_service unit tests

* Update optimizely unit tests

* Update bucketer unit tests

* Update Copyright year to include 2021

* Fix reported reasons and begin adding new unit tests

* Add test case when returning stored variation

* Add unit test when user is in forced variation

* Add more unit tests

* Change __checkIfUserIsInAudience method to return decision response and update unit tests

* Add unit test when user is not bucketed into targeting rule

* Refactor test setup and add more tests

* Clean up and add bucketing in group test

* Complete INCLUDE_REASONS default option tests

* Add decision response unit tests

* Incorporate comments part 1

* Add missing unit tests when user has forced variation

* Change DecisionReponse class to interface and update unit tests

* Remove console.log statement

893 of 1009 branches covered (88.5%)

Branch coverage included in aggregate %.

8627 of 8811 relevant lines covered (97.91%)

413.06 hits per line