356
93%

Ran 21 Sep 2015 03:50PM UTC

Jobs 1

Files 8

Run time 1s

Badge

Embed ▾

pending completion

Build # 356

Build Type

Pull #139

travis-ci

Committed by

dabura667

Commit Message

Double check validation

bitcore-mnemonic can not verify phrases with isValid in the (very rare) circumstances that: 
1. it is a mnemonic made with words common between 2 different wordlists
2. the checksum only matches for the wordlist which is a higher index on the list of wordlists within bitcore-mnemonic.

A mnemonic meeting those two rare cases will, when the language is unspecified, check all the words in each wordlist in order to find the wordlist. Since the first match is the wordlist used, and the checksum only matches the higher (later) indexed wordlist, it will be generated as a valid phrase but when checked, will be invalid (because we don't pass the language when checking the phrase in Copay)

A more long-term solution would be to change Copay to check the current locale's wordlist first when checking. (Without limiting ie. a French person from using a Japanese phrase or something)

However, this is a 1 in 100 quadrillion chance with English and French, so this simple fix might be fine for now.

Pull Request Pull Request #139: Double check validation

Run Details

1007 of 1067 relevant lines covered (94.38%)

57.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	356.1	21 Sep 2015 03:50PM UTC	8	94.38	Travis Job 356.1

Source Files on build 356

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

bitpay / bitcore-wallet-client / 356
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 356

bitpay / bitcore-wallet-client / 356 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 356

bitpay / bitcore-wallet-client / 356
93%

README BADGES
x