• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / ngas / 490
69%

Build:
DEFAULT BRANCH: master
Ran 12 Jan 2021 04:36AM UTC
Jobs 6
Files 163
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
490

push

travis-ci-com

Rodrigo Tobar
Return 411 when on invalid/missing Content-Length

As stated in NGAS-163, NGAS should respond with 411 rather than 400 when
requests with no Content-Length (or Content-Length=0) arrive, as the
codebase currently expects a Content-Length to be given.

To keep things consistent, instead of sending the response back directly
where the problem is identified, we instead simply raise a typed error,
which we then handle more centrally with the rest of the known errors.

The unit test checking that zero-length files cannot be archived has
been updated to double-check the HTTP status from the failing request.
Adding this check also made part of test_QArchive obsolete and
duplicate (it does exactly the same that test_FileSizeZero does), so I
removed the duplicate.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

7 of 7 new or added lines in 1 file covered. (100.0%)

13539 of 19612 relevant lines covered (69.03%)

4.12 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
4
100.0
src/ngamsServer/ngamsServer/ngamsArchiveUtils.py
23
100.0
src/ngamsCore/ngamsLib/ngamsStatus.py
Jobs
ID Job ID Ran Files Coverage
1 490.1 (DB=sqlite3) 12 Jan 2021 04:36AM UTC 0
68.74
Travis Job 490.1
2 490.2 (DB=mysql) 12 Jan 2021 04:37AM UTC 0
68.48
Travis Job 490.2
3 490.3 (DB=postgresql) 12 Jan 2021 04:37AM UTC 0
68.5
Travis Job 490.3
5 490.5 12 Jan 2021 04:36AM UTC 0
68.73
Travis Job 490.5
6 490.6 12 Jan 2021 04:36AM UTC 0
68.87
Travis Job 490.6
7 490.7 12 Jan 2021 04:36AM UTC 0
68.87
Travis Job 490.7
Source Files on build 490
  • Tree
  • List 163
  • Changed 13
  • Source Changed 3
  • Coverage Changed 12
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Build #490
  • e4c01977 on github
  • Prev Build on master (#488)
  • Next Build on master (#493)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc