ICRAR / ngas / 490

69%

push

travis-ci-com

Return 411 when on invalid/missing Content-Length

As stated in NGAS-163, NGAS should respond with 411 rather than 400 when
requests with no Content-Length (or Content-Length=0) arrive, as the
codebase currently expects a Content-Length to be given.

To keep things consistent, instead of sending the response back directly
where the problem is identified, we instead simply raise a typed error,
which we then handle more centrally with the rest of the known errors.

The unit test checking that zero-length files cannot be archived has
been updated to double-check the HTTP status from the failing request.
Adding this check also made part of test_QArchive obsolete and
duplicate (it does exactly the same that test_FileSizeZero does), so I
removed the duplicate.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

7 of 7 new or added lines in 1 file covered. (100.0%)

13539 of 19612 relevant lines covered (69.03%)

4.12 hits per line