qunitjs / qunit / 3167

89%

main: 90%

push

travis-ci-com

Core: Repair support for SpiderMonkey runtime

Three issues came up when trying to use QUnit in an embedded mozjs context.

1. console.warn is undefined.

   This regressed in a recent release where we started to assume that if
   'console' is defined, that 'console.warn' is as well.
   This is not true in SpiderMonkey (checked mozjs 68).

2. setTimeout is undefined.

   QUnit has historically made sure not to rely on setTimeout, but this broke
   when es6-promise was added in gh-1307, which assumed presence of setTimeout.
   The funny part is, mozjs 68 actually has native Promise support, but the
   polyfill is written in a way (and built in a way, with Rollup) that
   unconditionally builds and imports the fallback, even when it decides not to
   use it. It seems Rollup does not support importing files in a way that
   only executes the imported files conditionally (it always hoists imported files
   and executes imports before any other code). So, to fix this, I'm switching
   the polyfil library to a lighter alternative, and patching it with a
   conditional check on the inside rather than on the outside, so that it
   can be unconditionally imported by Rollup, but still only conditionally
   build its setTimeout-based fallback.

3. QUnit is not exported.

   I believe we used to have an export to the global object if no module loader
   was detected, but this morphed over time and we now hardcode global exports
   specifically for DOM global (window) and Web Worker global (self), which
   means it no longer worked in SpiderMonkey.

   Our current structure of the internal export.js file, is to provide any
   and all exports we can detect, which is rather unusual in the JS ecosystem,
   but it would also be a breaking change to stop doing this, so I'll reserve
   that for QUnit 3. This patch introduces a realm-agnostic global export if
   and only if no other export methods were applied.

   I suggest that in QUnit 3 we restructure this to simply ... (continued)

1172 of 1430 branches covered (81.96%)

2085 of 2333 relevant lines covered (89.37%)

349.34 hits per line