flux-framework / flux-core / 623

80%

Pull #408

travis-ci

<a href="https://github.com/flux-framework/flux-core/commit/<a class=hub.com/flux-framework/flux-core/commit/14b76d9a15ca976a71000bdd0bcd6ebc6e1832b4">14b76d9a1<a href="https://github.com/flux-framework/flux-core/commit/14b76d9a15ca976a71000bdd0bcd6ebc6e1832b4">&quot;&gt;build: fix make clean

code coverage enhancements in this commit broke &amp;quot;make clean&quot;

  commit </a><a class="double-link" href="https://github.com/flux-framework/flux-core/commit/<a class="double-link" href="https://github.com/flux-framework/flux-core/commit/4fee3a722d0cc4847b7a1084ed1dfe13610ba56d">4fee3a722</a>">4fee3a722</a><a href="https://github.com/flux-framework/flux-core/commit/14b76d9a15ca976a71000bdd0bcd6ebc6e1832b4">
  Author: Mark Grondona &lt;mark.grondona@gmail.com&gt;
  Date:   Mon Sep 14 03:52:56 2015 +0000

    build: remove coverage files on clean

    Remove *.gcno and baseline coverage output file on &#39;make clean&#39;
    when configured with --check-code-coverage.

because &#39;clean:&#39; was used as the target instead of &#39;clean-local&#39;.
But also the commands should have been wrapped in

 ifeq ($(CODE_COVERAGE_ENABLED),yes)
 endif

like the rest of the code coverage commands. However, use of ifeq()
doesn&#39;t work in Makefile.am files because of a conflict with Automake&#39;s
&quot;endif&quot; keyword.

Avoid this whole disaster and move our clean commands into the
config/ax_code_coverage.m4 so they are expanded cleanly with the
rest of @CODE_COVERAGE_RULES@.

13684 of 19394 relevant lines covered (70.56%)

195858.3 hits per line