13241
66%
master: 66%

Ran 17 Dec 2020 06:20PM UTC

Jobs 1

Files 109

Run time 29s

Badge

Embed ▾

Committed 17 Dec 2020 05:53PM UTC coverage: 65.3% (+0.05%) from 65.251%

Build # 13241

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Janitor: refactor to be controlled by config (#5195)

Previously, configuration of the boulder-janitor was split into
two places: the actual json config file (which controlled which
jobs would be enabled, and what their rate limits should be), and
the janitor code itself (which controlled which tables and columns
those jobs should query). This resulted in significant duplicated
code, as most of the jobs were identical except for their table
and column names.

This change abstracts away the query which jobs use to find work.
Instead of having each job type parse its own config and produce
its own work query (in Go code), now each job supplies just a few
key values (the table name and two column names) in its JSON config,
and the Go code assembles the appropriate query from there. We are
able to delete all of the files defining individual job types, and
replace them with a single slightly smarter job constructor.

This enables further refactorings, namely:
* Moving all of the logic code into its own module;
* Ensuring that the exported interface of that module is safe (i.e.
  that a client cannot create and run jobs without them being valid,
  because the only exposed methods ensure validity);
* Collapsing validity checks into a single location;
* Various renamings.

Run Details

13233 of 20265 relevant lines covered (65.3%)

0.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	13241.7 (TESTFLAGS="--coverage" CONTAINER="netaccess")	17 Dec 2020 06:19PM UTC	0	65.3	Travis Job 13241.7

Source Files on build 13241

Detailed source file information is not available for this build.

letsencrypt / boulder / 13241
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13241

letsencrypt / boulder / 13241 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13241

letsencrypt / boulder / 13241
66%
master: 66%

README BADGES
x