13237
66%
master: 66%

Ran 15 Dec 2020 11:04PM UTC

Jobs 1

Files 115

Run time 24s

Badge

Embed ▾

Committed 15 Dec 2020 10:38PM UTC coverage: 65.251% (-0.005%) from 65.256%

Build # 13237

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

ocsp-responder: move IssuerID check after Expires check (#5202)

It is possible for a CertificateStatus row to have a nil IssuerID
(there was a period of time in which we didn't write IssuerIDs into
CertificateStatus rows at all) but all such rows should be old and
therefore expired.

Unfortunately, this code was checking the IssuerID before it was
checking the Expiry, and therefore was generating panics when trying
to dereference a nil pointer.

This change simply moves the IssuerID check to be after the Expires
check, so that we'll only try to dereference the IssuerID on recent
CertificateStatus rows, where it is guaranteed to be non-nil.

Fixes #5200

Run Details

13310 of 20398 relevant lines covered (65.25%)

0.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	13237.7 (TESTFLAGS="--coverage" CONTAINER="netaccess")	15 Dec 2020 11:04PM UTC	0	65.25	Travis Job 13237.7

Source Files on build 13237

Detailed source file information is not available for this build.

letsencrypt / boulder / 13237
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13237

letsencrypt / boulder / 13237 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13237

letsencrypt / boulder / 13237
66%
master: 66%

README BADGES
x