91
89%

Ran 14 Sep 2015 06:16AM UTC

Jobs 2

Files 58

Run time 4min

Badge

Embed ▾

pending completion

Build # 91

Build Type

push

travis-ci

Committed by

warner

Commit Message

remove shared Listeners, Tub.listenOn(listener), .clone()

The thorny who-owns-the-Listener problem described in ticket:239 was
easiest to solve by removing the Foolscap feature of allowing Listeners
to be shared between multiple Tubs. With this change, each Listener has
exactly 0 or 1 parent Tub (zero-Tub Listeners aren't useful now, but
might be useful in the future when we implement redirects or relays).

It was also necessary to remove Tub.clone(), since it necessarily
produced shared Listeners.

We also remove Listener.addTub and .removeTub, since they're no longer
used, and simplify Listener internals (Listeners are now Services, and
the listening socket is a service child). This patch also removes the
static global "Listeners" array, which was only used for testing, but
felt like a bad idea anyways. And to finish the exercise, we've excised
the tests which exercised the excised feature.

refs ticket:239

Run Details

7631 of 8594 relevant lines covered (88.79%)

1.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	91.1	14 Sep 2015 06:16AM UTC	0	88.78	Travis Job 91.1
2	91.2	14 Sep 2015 06:16AM UTC	0	88.76	Travis Job 91.2

Source Files on build 91

Detailed source file information is not available for this build.

warner / foolscap / 91
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 91

warner / foolscap / 91 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 91

warner / foolscap / 91
89%

README BADGES
x