kubevirt / hyperconverged-cluster-operator / 4555

84%

main: 76%

push

travis-ci

Make uninstall safer and faster (#951)

kubectl/oc delete command by defaults
runs with --wait=true
and so it waits for resources to be gone
before returning.
This waits for finalizers.

The client-go from controller-runtime
instead doesn't implement that logic
that it's completely up to the caller.

Let's implement it in ComponentResourceRemoval
to be sure that the deletion is safe.
Use a context with 30 second timeouts to
avoid getting stuck forever in the middle of the delete.

Let's then try to delete other CRs
in parallel with goroutines
syncked with a wait group to make
the uninstall faster.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

521 of 622 relevant lines covered (83.76%)

25.78 hits per line