Brightspace / ksiren / 71

93%

push

travis-ci

Fix json encoding (#12)

* fix: add centralized JSON string escaping

* refact: remove unnecessary safe call operator; add tests checking for correct string escaping

* test: add comment to test data + minor nits (private func/var/readability)

* style: explicit iterator naming, function formatting

* refact: use class delegation to simplify MutableAction/MutableField

* fix: nullable type mismatches

* refact: create JsonWriter interface and use GSON/Moshi to serialize JSON with correct escaping

* refact: treat warnings as errors + remove unnecessary safe call operators

* chore: version bumps

* refact: let -> isNotEmpty(); chained value calls for consistency

* style: named iterator vs. it

* style: reformat for spacing

* refact: JSON writers implement Closeable/consumers use try-with-resources; use some more idiomatic patterns

* * Refactor JSON writer factory - was going for symmetry, but I see now why the reader has a not-quite-a-factory
* Action deepCopy simplification
* Use apply in pre-existing fluent interface for consistency
* Gradle dep version templating

* refact: remove redundant init in KSirenGsonWriter
style: whole-project formatting

Co-authored-by: Adam Palaniuk <Adam.Palaniuk@D2L.com>

127 of 127 new or added lines in 9 files covered. (100.0%)

392 of 425 relevant lines covered (92.24%)

0.92 hits per line