FAForever / server / 4115
96%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 68
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4115

push

travis-ci

GitHub 
Party system, team matchmaking (#423)

* SQUASHED: Add party system

* Add some more leave_party tests

* Add tests for set_factions

* Refactor Party and PartyService

* Clean up party invites, send party updates via dirty loop

* Create parties when ready/unready

* Ignore game_matchmaking start commands if player is not party owner

* Remove unused stuff in tests

* Start search for whole party when queueing

* Remove unused function 'remove_disbanded_parties'

* Select player faction from party preferences

Closes #613

* Ensure that players always have at least one faction choice selected

* Rework faction selection to use faction names

Using indices into a boolean array was confusing as it was non obvious what
each index represented. This lead to some immediate implementation mistakes
where the server implementation assumed that the indices mapped to their one
indexed lua counterparts, while the client implementation assumed that the
factions were sorted alphabetically from left to right. This new approach is
less error prone, requires fewer bytes to transfer the same information, and
is more flexible-- even allowing the selection of nomads or other future
faction for special game modes.

* Use double quotes for strings

* Remove party ready tracking

* Replace unused test accounts with generic accounts

* Save players old party state when switching parties

* Add unit tests for PlayerParty

* Choose player factions after a match is found

As searches can only be started by party owners, the guests may not have
decided what factions they want to pick when the owner enters them into the
matchmaker queue. Therefore we should allow them to change their faction
preferences up until the moment they are matched.

Fixes #679

* Replace 'invalid_state' messages with 'ClientError's

* Increase timeout for tests

* Rename queue to queue_name in match_found message

* Ensure that players cannot... (continued)

4579 of 4756 relevant lines covered (96.28%)

0.96 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4115.1 (FAF_DB_VERSION="v106") 0
96.28
 Travis Job 4115.1
Source Files on build 4115
Detailed source file information is not available for this build.