4528
70%
main: 76%

Ran 23 Nov 2020 01:20PM UTC

Jobs 1

Files 1

Run time 1s

Badge

Embed ▾

Committed 23 Nov 2020 01:14PM UTC coverage: 84.304% (-0.4%) from 84.743%

Build # 4528

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Add a mutating webhook to protect hco namespace (#949)

Introducing a mutating admission webhooks, deployed by
the OLM, bound to the namespace where HCO is running
to protect it from uneducated deletion the can
potentially made it stuck.
The webhook scope is limited to that specific namespace
by the use of an objectSelector.

In this first step the mutating webhook is simply refusing,
with a clear error message,to admit the deletion of the
namespace if the Hyperconverged CR is still there.
A future enhancement can try to delete the Hyperconverged CR
as a side effect (that's why a mutating webhook with side effects)
and, only when it and all its descendants are correctly
and safely deleted, admit the deletion of the namespace.
This requires other ancillary work to make the deletion safe
avoiding race conditions.
So let's simply refuse to delete the namespace as a first
and safer step.

Test it in CI at the end of upgrade test lanes:
the test will try to delete the namespace when the Hyperconverged CR
is still there looking for a specific error message,
the test then will delete the hyperconverged CR and finally
successfully delete the namespace.

Fixes: https://bugzilla.redhat.com/1881874

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Run Details

521 of 618 relevant lines covered (84.3%)

25.95 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4528.1	23 Nov 2020 01:20PM UTC	0	84.3	Travis Job 4528.1

Source Files on build 4528

Detailed source file information is not available for this build.

kubevirt / hyperconverged-cluster-operator / 4528
70%
main: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4528

kubevirt / hyperconverged-cluster-operator / 4528 70% main: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4528

kubevirt / hyperconverged-cluster-operator / 4528
70%
main: 76%

README BADGES
x