gnosis / dex-react / 4208

41%

push

travis-ci-com

V2 Tabs comments (#1629)

* TabItem knows too much

1. id is not needed here as it is passed in by the smart parent
2. isActive in Wrapper isnt needed as activeColor can indicate isActive

* simplify TabContent & change activeColor to required

* Tabs changes

1. simplified as no more need for id or isActive
2. destructure in props
3. remove implicit type form useState hook

* V2 Tabs - Separate PR addressing comments (#1634)

* Refactxor.

* Refactxor.

* Fix ts any.

* Update src/components/OrderBuySell/index.tsx

Support string/ReactNode for tab content.

Co-authored-by: David <david.sato64@gmail.com>

* Refactor tabs

* Remove console.log references

* Fix content check.

Co-authored-by: David <david.sato64@gmail.com>

* fix develop merge conflicts

* TabItem as button (merge error fix)

Co-authored-by: Michel <31534717+biocom@users.noreply.github.com>

400 of 1719 branches covered (23.27%)

Branch coverage included in aggregate %.

1777 of 3611 relevant lines covered (49.21%)

6.95 hits per line