qunitjs / qunit / 3035

89%

main: 90%

push

travis-ci-com

Core: Fix test counter bug when nesting invalid test functions (#1515)

This doesn't affect end-users, since nesting QUnit.test() calls
isn't supported. In our own unit tests, we assert early bail out
behaviour for passing invalid arguments to QUnit.test(), and naturally
we do this from inside another QUnit.test() call.

The previous code left bailed out *after* we had already registered
the test and handed out references to reporting code. This meant
that it would count this as two tests of which one had an unknown
state, which js-reporters casts to a failed test.

This wasn't caught in CI because:

- When we run the test via the HTML Reporter and via the
  test-on-node task, we report it via the legacy QUnit.testDone()
  and QUnit.done() which didn't pay attention to this half-known
  test.

- And we don't currently run this test via the QUnit CLI
  (if we did, it would be failing)

Fixes https://github.com/qunitjs/qunit/issues/1514

1167 of 1419 branches covered (82.24%)

2073 of 2317 relevant lines covered (89.47%)

350.38 hits per line