1244
42%

Ran 19 Nov 2020 11:00AM UTC

Jobs 6

Files 13

Run time 2min

Badge

Embed ▾

pending completion

Build # 1244

Build Type

push

travis-ci-com

Committed by

cathay4t

Commit Message

nm provider: Refactor the down action of network connection

When deactivating a profile in libNM, we should:

 * Check `NM.ActionConnection` existence
 * Check `NM.ActionConnection.props.state` not DEACTIVATED
 * Use signal `state-changed` of `NM.ActionConnection`.
 * Only invoke `NM.Client.deactivate_connection_async()` if not
   in DEACTIVATING state.
 * Ignore `NM.ManagerError.CONNECTIONNOTACTIVE` error.

This patch also introduced a new class `NetworkManagerProvider`
in `module_utils/network_lsr/nm`:

 * Independent from Ansible but need to use absolute import due to
   limitation of ansible 2.8.
 * Provide sync function wrapping async calls of libNM.
 * Use stable logging method of python.
 * Only load this module when provider is nm.

This patch also changed how logging is handling in
`Cmd_nm.run_action_down()` as initial step on isolate ansible log
mechanism from provider module.

By moving provider codes to `module_utils` folder, we can eventually
simplify the bloated `library/network_connections.py`.

Signed-off-by: Gris Ge <fge@redhat.com>

Run Details

948 of 2409 relevant lines covered (39.35%)

2.36 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	*1244.1 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:00AM UTC	39.25	Travis Job 1244.1
2	*1244.2 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:02AM UTC	39.27	Travis Job 1244.2
3	*1244.3 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:02AM UTC	39.19	Travis Job 1244.3
4	*1244.4 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:00AM UTC	39.19	Travis Job 1244.4
5	*1244.5 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:00AM UTC	40.35	Travis Job 1244.5
6	*1244.6 (LSR_ANSIBLES='ansible==2.7. ansible==2.8.* ansible==2.9.' LSR_MSCENARIOS='default')*	19 Nov 2020 11:02AM UTC	40.35	Travis Job 1244.6

Source Files on build 1244

Detailed source file information is not available for this build.

linux-system-roles / network / 1244
42%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1244

linux-system-roles / network / 1244 42%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1244

linux-system-roles / network / 1244
42%

README BADGES
x